qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/7] pci: initialize ids in pci common code


From: Isaku Yamahata
Subject: Re: [Qemu-devel] [PATCH 0/7] pci: initialize ids in pci common code
Date: Fri, 6 May 2011 00:52:12 +0900
User-agent: Mutt/1.5.19 (2009-01-05)

On Thu, May 05, 2011 at 03:41:57PM +0300, Michael S. Tsirkin wrote:
> On Fri, Apr 08, 2011 at 09:52:59PM +0900, Isaku Yamahata wrote:
> > vender id/device id... in configuration space are read-only registers
> > which are commonly defined for all pci devices.
> > So initialize them in common code and it simplifies the initialization a 
> > bit.
> > I converted some of them.
> > 
> > If this is the right direction, I'll convert the remaining devices.
> 
> So I agree about device vendor id and revision but not header type:
> devices ideally should supply device type (bridge or not)
> and we will fill it in correctly.

Okay, with the nextspin, I'll drop program interface and header type
and add assert for subsystem id/vendor id.
-- 
yamahata



reply via email to

[Prev in Thread] Current Thread [Next in Thread]