[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2] eepro100: Update of patch series (fixes and e
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL v2] eepro100: Update of patch series (fixes and enhancements) |
Date: |
Thu, 5 May 2011 16:01:12 +0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Apr 30, 2011 at 10:40:03PM +0200, Stefan Weil wrote:
> Hi,
>
> this is the second version of a series of patches for eepro100 which mainly
> fix endianness issues and enhance register access. There was a bug report
> on qemu-devel recently which is fixed by these enhancements, see
> http://lists.nongnu.org/archive/html/qemu-devel/2011-03/msg02109.html.
>
> Changes in v2:
>
> * The 2nd patch is new.
>
> * Patches are sorted in a different order. The first 4 patches and the
> rest are independent, so it's possible to apply parts of the series.
>
> * The endianness patch was updated to address the feedback which I received.
> I still use local functions to access physical memory - mainly because
> I want to use cpu_physical_memory_read / cpu_physical_memory_write as long
> as I am not sure whether the alignment requirements for the suggested
> open coded variant are met.
> The prefix is e100 - shorter and more up-to-date than eepro100.
> When I started this device emulation, linux still used a module called
> eepro100. Today, the only linux module is called e100. So my final goal
> is renaming all eepro100 to e100.
>
> I did not change the patch which adds padding to short received frames,
> because I'd like to keep the preprocessor statement
> (CONFIG_PAD_RECEIVED_FRAMES)
> as some kind of documentation (even if QEMU's network code won't be modified
> in the near future to fully support a real ethernet emulation).
>
> Kind regards,
>
> Stefan W.
>
Applied with a small tweak, thanks!
- Re: [Qemu-devel] [PULL v2] eepro100: Update of patch series (fixes and enhancements),
Michael S. Tsirkin <=