Re: [Qemu-devel] [PATCH 6/6] PPC: Qdev'ify e500 pci

[Alexander Graf]

On 04.05.2011, at 21:08, Blue Swirl wrote:

> On Mon, May 2, 2011 at 6:03 PM, Alexander Graf <address@hidden> wrote:
>> The e500 PCI controller isn't qdev'ified yet. This leads to severe issues
>> when running with -drive.
>> 
>> To be able to use a virtio disk with an e500 VM, let's convert the PCI
>> controller over to qdev.
>> 
>> Signed-off-by: Alexander Graf <address@hidden>
>> 
>> ---
>> 
>> v2 -> v3:
>> 
>>  - rebase to current code base
>>  - fix endian issue
>>  - use sysbus helpers
>> ---
>>  hw/ppce500_pci.c |  112 
>> +++++++++++++++++++++++++++++++++++-------------------
>>  1 files changed, 73 insertions(+), 39 deletions(-)
>> 
>> diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c
>> index 83a20e4..88bc759 100644
>> --- a/hw/ppce500_pci.c
>> +++ b/hw/ppce500_pci.c
>> @@ -73,11 +73,11 @@ struct pci_inbound {
>>  };
>> 
>>  struct PPCE500PCIState {
>> +    PCIHostState pci_state;
>>     struct pci_outbound pob[PPCE500_PCI_NR_POBS];
>>     struct pci_inbound pib[PPCE500_PCI_NR_PIBS];
>>     uint32_t gasket_time;
>> -    PCIHostState pci_state;
>> -    PCIDevice *pci_dev;
>> +    uint64_t base_addr;
> 
> This does not seem to be used. Also devices shouldn't care about their
> base addresses.

Oops - must have missed that one :). Thanks!


Alex