Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements)

[Anthony Liguori]

On 04/28/2011 12:44 PM, Stefan Weil wrote:
> Am 28.04.2011 19:39, schrieb Anthony Liguori:
> > On 04/28/2011 12:08 PM, Stefan Weil wrote:
> > > From: Stefan Weil<address@hidden>
> > >
> > > Commit 353ac78d495ef976242abd868f68d78420861c2c moved the files
> > > without fixing the include paths.
> > >
> > > Signed-off-by: Stefan Weil<address@hidden>
> >
> >
> > This is not correct. I think we learned in IRC that the problem is
> > Stefan is using CFLAGS=-g which overrides the CFLAGS append added by
> > this patch.
> >
> > Regards,
> >
> > Anthony Liguori
>
>
> QEMU Makefiles use QEMU_CFLAGS - setting CFLAGS in Makefile* is wrong,
> because now users can no longer set their own CFLAGS.

Use ./configure --extra-cflags="-g"

Regards,

Anthony Liguori


> The special CFLAGS for virtio should be removed (with my patch applied
> first).
> The second best solution would be changing CFLAGS to QEMU_CFLAGS in
> Makefile.objs and Makefile.target.
>
> Regards,
>
> Stefan