[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/6] char: Allow devices to use a single multiplexed
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH 4/6] char: Allow devices to use a single multiplexed chardev. |
Date: |
Thu, 28 Apr 2011 13:00:51 +0530 |
From: Kusanagi Kouichi <address@hidden>
This fixes regression caused by commit
2d6c1ef40f3678ab47a4d14fb5dadaa486bfcda6
("char: Prevent multiple devices opening same chardev"):
-nodefaults -nographic -chardev stdio,id=stdio,mux=on,signal=off \
-mon stdio -device virtio-serial-pci \
-device virtconsole,chardev=stdio -device isa-serial,chardev=stdio
fails with:
qemu-system-x86_64: -device isa-serial,chardev=stdio: Property
'isa-serial.chardev' can't take value 'stdio', it's in use
Signed-off-by: Kusanagi Kouichi <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
---
hw/qdev-properties.c | 4 ++--
qemu-char.c | 5 ++++-
qemu-char.h | 2 +-
3 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 1088a26..eff2d24 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -354,10 +354,10 @@ static int parse_chr(DeviceState *dev, Property *prop,
const char *str)
if (*ptr == NULL) {
return -ENOENT;
}
- if ((*ptr)->assigned) {
+ if ((*ptr)->avail_connections < 1) {
return -EEXIST;
}
- (*ptr)->assigned = 1;
+ --(*ptr)->avail_connections;
return 0;
}
diff --git a/qemu-char.c b/qemu-char.c
index 710d98f..eaf6571 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -199,7 +199,7 @@ void qemu_chr_add_handlers(CharDriverState *s,
{
if (!opaque) {
/* chr driver being released. */
- s->assigned = 0;
+ ++s->avail_connections;
}
s->chr_can_read = fd_can_read;
s->chr_read = fd_read;
@@ -2547,7 +2547,10 @@ CharDriverState *qemu_chr_open_opts(QemuOpts *opts,
snprintf(base->label, len, "%s-base", qemu_opts_id(opts));
chr = qemu_chr_open_mux(base);
chr->filename = base->filename;
+ chr->avail_connections = MAX_MUX;
QTAILQ_INSERT_TAIL(&chardevs, chr, next);
+ } else {
+ chr->avail_connections = 1;
}
chr->label = qemu_strdup(qemu_opts_id(opts));
return chr;
diff --git a/qemu-char.h b/qemu-char.h
index 2f8512e..892c6da 100644
--- a/qemu-char.h
+++ b/qemu-char.h
@@ -72,7 +72,7 @@ struct CharDriverState {
char *label;
char *filename;
int opened;
- int assigned; /* chardev assigned to a device */
+ int avail_connections;
QTAILQ_ENTRY(CharDriverState) next;
};
--
1.7.4.4
- [Qemu-devel] [PULL] char, virtio-serial, spice, Amit Shah, 2011/04/28
- [Qemu-devel] [PATCH 3/6] spice-chardev: listen to frontend guest open / close, Amit Shah, 2011/04/28
- [Qemu-devel] [PATCH 1/6] chardev: Allow frontends to notify backends of guest open / close, Amit Shah, 2011/04/28
- [Qemu-devel] [PATCH 4/6] char: Allow devices to use a single multiplexed chardev.,
Amit Shah <=
- [Qemu-devel] [PATCH 2/6] virtio-console: notify backend of guest open / close, Amit Shah, 2011/04/28
- [Qemu-devel] [PATCH 5/6] char: Detect chardev release by NULL handlers as well as NULL opaque, Amit Shah, 2011/04/28
- [Qemu-devel] [PATCH 6/6] virtio-serial: Fix endianness bug in the config space, Amit Shah, 2011/04/28
- Re: [Qemu-devel] [PULL] char, virtio-serial, spice, Anthony Liguori, 2011/04/28