[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GES
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GESN |
Date: |
Mon, 11 Apr 2011 11:48:09 +0530 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On (Fri) 08 Apr 2011 [11:39:26], Markus Armbruster wrote:
> Results of quick test run now, patch review to follow.
>
> Test uses a simple program to try ioctl CDROM_DRIVE_STATUS (attached).
...
> Test in guest without your patches:
>
> [start with empty drive]
> # ./drive-status
> CDS_NO_DISC
> # eject /dev/sr0
> # ./drive-status
> CDS_NO_DISC
> [incorrect, should be CDS_TRAY_OPEN]
> # eject -t /dev/sr0
> # ./drive-status
> CDS_NO_DISC
> [insert media with monitor command change]
> # ./drive-status
> CDS_DISC_OK
> # eject /dev/sr0
> # ./drive-status
> CDS_NO_DISC
> [incorrect, should be CDS_TRAY_OPEN]
> # eject -t /dev/sr0
> # ./drive-status
> CDS_DISC_OK
>
> With the patches, it behaves as expected. Except something (guest
> kernel?) closes the tray right after eject if there's a medium in the
> open tray.
Can you try with the two patches I sent on Saturday:
atapi: Drives can be locked without media present
atapi: Report correct errors on guest eject request
Thanks,
Amit
- [Qemu-devel] Re: [PATCH 3/5] atapi: GESN: Spin off No Event Available handling into own function, (continued)
[Qemu-devel] [PATCH 4/5] atapi: GESN: Add enums for commonly-used field types, Amit Shah, 2011/04/08
[Qemu-devel] [PATCH 5/5] atapi: Implement 'media' subcommand of GET_EVENT_STATUS_NOTIFICATION command, Amit Shah, 2011/04/08
[Qemu-devel] Re: [PATCH 0/5] atapi: Implement 'media' subcommand for GESN, Paolo Bonzini, 2011/04/08
Re: [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GESN, Markus Armbruster, 2011/04/08
- Re: [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GESN,
Amit Shah <=