[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 3/5] target-i386: fix cpu-exec.o build with soft
From: |
Peter Maydell |
Subject: |
[Qemu-devel] Re: [PATCH 3/5] target-i386: fix cpu-exec.o build with softfloat |
Date: |
Sun, 10 Apr 2011 21:18:33 +0100 |
On 10 April 2011 20:13, Aurelien Jarno <address@hidden> wrote:
> Fixing the definition of CPU86_LDoubleU allow building cpu-exec.o with
> softfloat.
>
> Cc: Peter Maydell <address@hidden>
> Signed-off-by: Aurelien Jarno <address@hidden>
> ---
> target-i386/exec.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/exec.h b/target-i386/exec.h
> index 6f9f709..d6922f3 100644
> --- a/target-i386/exec.h
> +++ b/target-i386/exec.h
> @@ -145,7 +145,7 @@ static inline void svm_check_intercept(uint32_t type)
>
> /* only for x86 */
> typedef union {
> - long double d;
> + floatx80 d;
> struct {
> unsigned long long lower;
> unsigned short upper;
> @@ -164,7 +164,7 @@ typedef union {
>
> /* NOTE: arm is horrible as double 32 bit words are stored in big endian ! */
> typedef union {
> - double d;
> + float64 d;
> #if !defined(HOST_WORDS_BIGENDIAN) && !defined(__arm__)
> struct {
> uint32_t lower;
I note that the !USE_X86LDOUBLE typedef for CPU86_LDoubleU is an
out-of-date version of cpu-all.h's CPU_DoubleU (it doesn't
get the ARM VFP endianness right).
Given patch 1 in this series, is it possible now just to have
#ifdef USE_X86LDOUBLE
typedef CPU_LDoubleU CPU86_LDoubleU;
/* other stuff */
#else
typedef CPU_DoubleU CPU86_LDoubleU;
/* ... */
#endif
?
-- PMM
- [Qemu-devel] [PATCH 1/5] cpu-all.h: define CPU_LDoubleU, Aurelien Jarno, 2011/04/10
- [Qemu-devel] [PATCH 2/5] target-i386: use CPU_LDoubleU instead of a private union, Aurelien Jarno, 2011/04/10
- [Qemu-devel] [PATCH 3/5] target-i386: fix cpu-exec.o build with softfloat, Aurelien Jarno, 2011/04/10
- [Qemu-devel] Re: [PATCH 3/5] target-i386: fix cpu-exec.o build with softfloat,
Peter Maydell <=
- [Qemu-devel] [PATCH 4/5] softfloat: add float{32, 64, x80, 128}_unordered() functions, Aurelien Jarno, 2011/04/10
- [Qemu-devel] [PATCH 5/5] target-i386: add floatx_{add, mul, sub} and use them, Aurelien Jarno, 2011/04/10