Re: [Qemu-devel] [PATCH] configure: avoid basename usage message

[Scott Wood]

On Fri, 8 Apr 2011 15:06:57 -0500
Anthony Liguori <address@hidden> wrote:

> On 04/08/2011 01:56 PM, Stefan Hajnoczi wrote:
> > On Fri, Apr 08, 2011 at 11:33:49AM -0500, Scott Wood wrote:
> >> diff --git a/configure b/configure
> >> index ae97e11..c5b85fe 100755
> >> --- a/configure
> >> +++ b/configure
> >> @@ -1233,7 +1233,8 @@ else
> >>     fi
> >>     sdl=no
> >>   fi
> >> -if test -n "$cross_prefix"&&  test "`basename $sdlconfig`" = sdl-config; 
> >> then
> >> +if test -n "$cross_prefix" -a -n "$sdlconfig"&&  \
> >> +   test "`basename $sdlconfig`" = sdl-config; then
> > Instead of doing test -n "$sdlconfig" first with short-circuit
> > evaluation, I think would should do:
> >
> > test $(basename "$sdlconfig") = sdl-config
> 
> $() is a bash-ism FYI.

See section 2.6.3 of
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html

And I've tested that it works in dash.

-Scott