Re: [Qemu-devel] [PATCH] configure: avoid basename usage message

[Stefan Hajnoczi]

On Fri, Apr 08, 2011 at 11:33:49AM -0500, Scott Wood wrote:
> diff --git a/configure b/configure
> index ae97e11..c5b85fe 100755
> --- a/configure
> +++ b/configure
> @@ -1233,7 +1233,8 @@ else
>    fi
>    sdl=no
>  fi
> -if test -n "$cross_prefix" && test "`basename $sdlconfig`" = sdl-config; then
> +if test -n "$cross_prefix" -a -n "$sdlconfig" && \
> +   test "`basename $sdlconfig`" = sdl-config; then

Instead of doing test -n "$sdlconfig" first with short-circuit
evaluation, I think would should do:

test $(basename "$sdlconfig") = sdl-config

Then you don't need to test sdlconfig because basename will produce an
empty string without error.

Stefan