[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 0/5] atapi: Implement 'media' subcommand for GES
[Qemu-devel] Re: [PATCH 0/5] atapi: Implement 'media' subcommand for GESN
Fri, 08 Apr 2011 09:21:54 +0200
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:126.96.36.199) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7
On 04/08/2011 09:15 AM, Amit Shah wrote:
The GET_EVENT_STATUS_NOTIFICATION ATAPI command is listed as a
mandatory command in the spec but we don't really implement it any of
The commit message for the last commit explains why implementing just
the media subcommand is helpful and how it goes a long way in getting
guests to behave as expected.
The difference from the RFC series sent earlier is:
- Split into more patches
- Add tray open/close notification (from Markus)
There certainly is much more work to be done for the other commands
and also for state change handling (tray open / close / new media)
overall for the block layer, but this is a good first step in being
spec-compliant and at the same time making guests work.
Amit Shah (5):
atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change
ide: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own
atapi: GESN: Spin off No Event Available handling into own function
atapi: GESN: Add enums for commonly-used field types
atapi: Implement 'media' subcommand of GET_EVENT_STATUS_NOTIFICATION
hw/ide/core.c | 172 +++++++++++++++++++++++++++++++++++++++++++++++-----
hw/ide/internal.h | 6 ++
2 files changed, 161 insertions(+), 17 deletions(-)
ACK patches 1-3.
For 4 and 5, I don't think lowercase enums are used in QEMU. I'm
downloading the spec now so I can do a more complete review as well.