[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 0/5] kvm/vhost: enable durty logging during
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH RFC 0/5] kvm/vhost: enable durty logging during memory registration |
Date: |
Thu, 7 Apr 2011 20:01:45 +0300 |
On Thu, Apr 7, 2011 at 8:39 AM, Brad Hards <address@hidden> wrote:
> On Thu, 7 Apr 2011 06:41:35 am Michael S. Tsirkin wrote:
>> As a solution, this adds an explicit flag that
>> will enable dirty logging directly when registering
>> the ram. kvm then needs a single system call
>> to update tables for vga ram, vhost-net can simply ignore it.
> I'm not very familiar with QEMU coding style and standards (so this could be
> completely bogus), but I think that the code would be easier if you used a
> integer flag / enum instead of a boolean. That would also give you options for
> additional behaviour changes later too. So instead of passing true/false, pass
> MEM_LOG_DIRTY_PAGES (or whatever you decide to call it).
Good idea, it's more descriptive.
Maybe also calls to qemu_register_coalesced_mmio() could be avoided
with another flag?
- [Qemu-devel] [PATCH RFC 0/5] kvm/vhost: enable durty logging during memory registration, Michael S. Tsirkin, 2011/04/06
- [Qemu-devel] [PATCH RFC 1/5] cpu: add set_memory flag to request dirty logging, Michael S. Tsirkin, 2011/04/06
- [Qemu-devel] [PATCH RFC 5/5] cirrus_vga: flag on-device ram for dirty logging, Michael S. Tsirkin, 2011/04/06
- [Qemu-devel] [PATCH RFC 4/5] vhost: optimize out no-change assignment, Michael S. Tsirkin, 2011/04/06
- [Qemu-devel] [PATCH RFC 2/5] kvm: halve number of set memory calls for vga, Michael S. Tsirkin, 2011/04/06
- [Qemu-devel] [PATCH RFC 3/5] vhost: skip memory which needs dirty logging, Michael S. Tsirkin, 2011/04/06
- Re: [Qemu-devel] [PATCH RFC 0/5] kvm/vhost: enable durty logging during memory registration, Brad Hards, 2011/04/07
- Re: [Qemu-devel] [PATCH RFC 0/5] kvm/vhost: enable durty logging during memory registration,
Blue Swirl <=