qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] lan9118: Ignore write to MAC_VLAN1 register


From: Aurelien Jarno
Subject: Re: [Qemu-devel] [PATCH] lan9118: Ignore write to MAC_VLAN1 register
Date: Mon, 4 Apr 2011 20:15:30 +0200
User-agent: Mutt/1.5.20 (2009-06-14)

On Tue, Mar 29, 2011 at 10:41:12PM +0900, Atsushi Nemoto wrote:
> Since kernel 2.6.38, smsc911x driver writes to VLAN1 registger.
> 
> Signed-off-by: Atsushi Nemoto <address@hidden>
> ---
>  hw/lan9118.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/lan9118.c b/hw/lan9118.c
> index af6949f..62aead3 100644
> --- a/hw/lan9118.c
> +++ b/hw/lan9118.c
> @@ -785,6 +785,8 @@ static void do_mac_write(lan9118_state *s, int reg, 
> uint32_t val)
>      case MAC_FLOW:
>          s->mac_flow = val & 0xffff0000;
>          break;
> +    case MAC_VLAN1:
> +        break; /* just ignore */
>      default:
>          hw_error("lan9118: Unimplemented MAC register write: %d = 0x%x\n",
>                   s->mac_cmd & 0xf, val);

Is it really safe ignoring write to this register? If yes, it's probably
a good idea to explain why in a comment. In any case, if supporting this
register is easy to do, it would be the best option.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net



reply via email to

[Prev in Thread] Current Thread [Next in Thread]