|
From: | Stefan Berger |
Subject: | Re: [Qemu-devel] [PATCH V1 2/8] Provide ACPI SSDT table for TPM device + S3 resume support |
Date: | Mon, 04 Apr 2011 10:52:44 -0400 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7 |
On 04/04/2011 12:17 AM, Kevin O'Connor wrote:
On Wed, Mar 30, 2011 at 01:55:36PM -0400, Stefan Berger wrote:This patch provides ACPI support for the TPM device. It probes for the TPM device and only if a TPM device is found then the TPM's SSDT and TCPA table are created. This patch also connects them to the RSDT.[...]// Space to reserve in high-memory for tables -#define CONFIG_MAX_HIGHTABLE (64*1024) +#if CONFIG_TCGBIOS +# define CONFIG_MAX_HIGHTABLE (96*1024) +#else +# define CONFIG_MAX_HIGHTABLE (64*1024) +#endifI'm a bit confused on patch ordering - it seems CONFIG_TCGBIOS is defined in patch 4 but used in patch 2.
I had it in patch 2 since there I am allocating 64kb in the high memory... I'll move it to patch 4.
Also, I'd prefer to avoid ifdefs - just up the size to 96 always, or do something like: #define CONFIG_MAX_HIGHTABLE ((64*1024) + CONFIG_TCGBIOS*(32*1024))
Done that. Stefan
-Kevin
[Prev in Thread] | Current Thread | [Next in Thread] |