[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 24/26] Implement PAPR virtual SCSI interface (ib
|
From: |
Benjamin Herrenschmidt |
|
Subject: |
[Qemu-devel] Re: [PATCH 24/26] Implement PAPR virtual SCSI interface (ibmvscsi) |
|
Date: |
Thu, 17 Mar 2011 07:08:47 +1100 |
On Wed, 2011-03-16 at 17:41 +0100, Alexander Graf wrote:
> > +/*
> > + * Common MAD header
> > + */
> > +struct mad_common {
> > + uint32_t type;
> > + uint16_t status;
> > + uint16_t length;
> > + uint64_t tag;
>
> Is this an in-memory representation? If so, it should be packed, right?
> Same goes for the ones below.
Well, all the fields are naturally aligned, as is the structure itself,
do we really need to pack ?
Cheers,
Ben.
- [Qemu-devel] Re: [PATCH 25/26] Add a PAPR TCE-bypass mechanism for the pSeries machine, (continued)
[Qemu-devel] [PATCH 22/26] Implement sPAPR Virtual LAN (ibmveth), David Gibson, 2011/03/16
[Qemu-devel] [PATCH 24/26] Implement PAPR virtual SCSI interface (ibmvscsi), David Gibson, 2011/03/16