[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1/5] Introduce -display argument
From: |
Anthony Liguori |
Subject: |
[Qemu-devel] Re: [PATCH 1/5] Introduce -display argument |
Date: |
Mon, 14 Mar 2011 08:37:23 -0500 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8 |
On 03/14/2011 07:28 AM, address@hidden wrote:
From: Jes Sorensen<address@hidden>
This patch introduces a -display argument which consolidates the
setting of the display mode. Valid options are:
sdl/curses/default/nographic
Signed-off-by: Jes Sorensen<address@hidden>
I'd suggest using 'serial' instead of 'nographic' as that makes it more
obvious to the user that they need to configure a serial session.
I would drop 'default' for no other reason than we don't really expose
default as a choice anywhere else and I'm struggling to justify it to
myself.
I think we also need to leave room to make -display take per-display
specific parameters via QemuOpts. That said, converting -vnc to
QemuOpts is hard so what I'd suggest doing is just cheating for the
moment. Document the option to take per-display args after the main
display, and then do something like:
if (strstarts(optarg, "vnc,", &p)) {
vnc_display_init(p);
}
We have a bunch of little stupid SDL options like -sdl-no-frame and it
would be good to eventually be able to express that as -display
sdl,frame=off
Regards,
Anthony Liguori
- [Qemu-devel] [PATCH 0/5] Introduce -display and make VNC optional, Jes . Sorensen, 2011/03/14
- [Qemu-devel] [PATCH 2/5] Introduce -display none, Jes . Sorensen, 2011/03/14
- [Qemu-devel] [PATCH 1/5] Introduce -display argument, Jes . Sorensen, 2011/03/14
- [Qemu-devel] [PATCH 5/5] Make VNC support optional, Jes . Sorensen, 2011/03/14
- [Qemu-devel] [PATCH 3/5] error message if user specifies SDL cmd line option when SDL is disabled, Jes . Sorensen, 2011/03/14
- [Qemu-devel] [PATCH 4/5] error message if user specifies curses on cmd line when curses is disabled, Jes . Sorensen, 2011/03/14