[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [V6 PATCH 8/9] virtio-9p: Move file post creation changes t
From: |
M. Mohan Kumar |
Subject: |
[Qemu-devel] [V6 PATCH 8/9] virtio-9p: Move file post creation changes to none security model |
Date: |
Mon, 28 Feb 2011 16:52:35 +0530 |
After creating a file object, its permission and ownership details are updated
as per 9p client's request for both passthrough and none security model.
But with chrooted environment its not required for passthrough security model.
Move all post file creation changes to none security model.
Signed-off-by: M. Mohan Kumar <address@hidden>
---
hw/9pfs/virtio-9p-local.c | 19 ++++++-------------
1 files changed, 6 insertions(+), 13 deletions(-)
diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c
index c92c5dd..f5dba35 100644
--- a/hw/9pfs/virtio-9p-local.c
+++ b/hw/9pfs/virtio-9p-local.c
@@ -163,21 +163,14 @@ static int local_set_xattr(const char *path, FsCred
*credp)
return 0;
}
-static int local_post_create_passthrough(FsContext *fs_ctx, const char *path,
+static int local_post_create_none(FsContext *fs_ctx, const char *path,
FsCred *credp)
{
+ int retval;
if (chmod(rpath(fs_ctx, path), credp->fc_mode & 07777) < 0) {
return -1;
}
- if (lchown(rpath(fs_ctx, path), credp->fc_uid, credp->fc_gid) < 0) {
- /*
- * If we fail to change ownership and if we are
- * using security model none. Ignore the error
- */
- if (fs_ctx->fs_sm != SM_NONE) {
- return -1;
- }
- }
+ retval = lchown(rpath(fs_ctx, path), credp->fc_uid, credp->fc_gid);
return 0;
}
@@ -318,7 +311,7 @@ static int local_mknod(FsContext *fs_ctx, const char *path,
FsCred *credp)
if (err == -1) {
return err;
}
- err = local_post_create_passthrough(fs_ctx, path, credp);
+ err = local_post_create_none(fs_ctx, path, credp);
if (err == -1) {
serrno = errno;
goto err_end;
@@ -360,7 +353,7 @@ static int local_mkdir(FsContext *fs_ctx, const char *path,
FsCred *credp)
if (err == -1) {
return err;
}
- err = local_post_create_passthrough(fs_ctx, path, credp);
+ err = local_post_create_none(fs_ctx, path, credp);
if (err == -1) {
serrno = errno;
goto err_end;
@@ -435,7 +428,7 @@ static int local_open2(FsContext *fs_ctx, const char *path,
int flags,
if (fd == -1) {
return fd;
}
- err = local_post_create_passthrough(fs_ctx, path, credp);
+ err = local_post_create_none(fs_ctx, path, credp);
if (err == -1) {
serrno = errno;
goto err_end;
--
1.7.3.4
- [Qemu-devel] [V6 PATCH 0/9] virtio-9p: Use chroot to safely access files in passthrough security model, M. Mohan Kumar, 2011/02/28
- [Qemu-devel] [V6 PATCH 1/9] Implement qemu_read_full, M. Mohan Kumar, 2011/02/28
- [Qemu-devel] [V6 PATCH 8/9] virtio-9p: Move file post creation changes to none security model,
M. Mohan Kumar <=
- [Qemu-devel] [V6 PATCH 2/9] virtio-9p: Enable CONFIG_THREAD if CONFIG_VIRTFS is enabled, M. Mohan Kumar, 2011/02/28
- [Qemu-devel] [V6 PATCH 3/9] virtio-9p: Provide chroot daemon side interfaces, M. Mohan Kumar, 2011/02/28
- [Qemu-devel] [V6 PATCH 6/9] virtio-9p: Create support in chroot environment, M. Mohan Kumar, 2011/02/28
- [Qemu-devel] [V6 PATCH 5/9] virtio-9p: Add support to open a file in chroot environment, M. Mohan Kumar, 2011/02/28
- [Qemu-devel] [V6 PATCH 9/9] virtio-9p: Chroot environment for other functions, M. Mohan Kumar, 2011/02/28
- [Qemu-devel] [V6 PATCH 4/9] virtio-9p: Add qemu side interfaces for chroot environment, M. Mohan Kumar, 2011/02/28
- [Qemu-devel] [V6 PATCH 7/9] virtio-9p: Support for creating special files, M. Mohan Kumar, 2011/02/28