Re: [Qemu-devel] Re: kvm crashes with spice while loading qxl

[Alon Levy]

On Sun, Feb 27, 2011 at 08:11:26PM +0100, Jan Kiszka wrote:
> On 2011-02-27 20:03, Alon Levy wrote:
> > On Sat, Feb 26, 2011 at 01:29:01PM +0100, Jan Kiszka wrote:
> >> On 2011-02-26 12:43, xming wrote:
> >>> When trying to start X (and it loads qxl driver) the kvm process just 
> >>> crashes.
> > 
> > This is fixed by Gerd's attached patch (taken from rhel repository, don't 
> > know
> > why it wasn't pushed to qemu-kvm upstream). I'll send it to kvm list as 
> > well (separate email).
> 
> Patch looks OK on first glance, but the changelog is misleading: This
> was broken for _both_ trees, but upstream didn't detect the bug.
> 

The trees the patch commit message refers to are qemu and qemu-kvm. qemu 
doesn't even
have cpu_single_env. It didn't talk about two qemu-kvm trees.

> My concerns regarding other side effects of juggling with global mutex
> in spice code remain.

I know there used to be a mutex in spice code and during the upstreaming 
process it
got ditched in favor of the qemu global io mutex. I would have rather deferred 
this
to Gerd since he wrote this, but he is not available atm.

> 
> Jan
>