Re: [Xen-devel] Re: [Qemu-devel] [PATCH V10 02/15] xen: Make xen build only on x86 target.

[Jan Kiszka]

On 2011-02-24 18:27, Anthony Liguori wrote:
> On 02/24/2011 10:25 AM, Anthony PERARD wrote:
>> On Thu, Feb 24, 2011 at 16:11, Anthony Liguori<address@hidden>  wrote:
>>    
>>> Is this really necessary?  The advantage to building globally is that it
>>> keeps the code from getting unnecessary i386-isms.
>>>      
>> Nop, is not necessary, I add this patch after this mail:
>> http://lists.nongnu.org/archive/html/qemu-devel/2010-12/msg00044.html
>>    
> 
> Alex, do you feel strongly here?

I'm not Alex, but I brought this issue up:

Either build xen bits once for all archs or restrict it to the only
foreseeable arch with support in qemu. But please don't built it for
each and every target separately.

BTW:

> index b0ba95f..db29e96 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -206,7 +206,9 @@ QEMU_CFLAGS += $(VNC_JPEG_CFLAGS)
>  QEMU_CFLAGS += $(VNC_PNG_CFLAGS)
>  
>  # xen backend driver support
> -obj-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o
> +obj-$(CONFIG_XEN) += xen_backend.o xen_devconfig.o
> +obj-$(CONFIG_XEN) += xen_console.o xenfb.o xen_disk.o xen_nic.o
> +obj-i386-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o

Why restricting the last line to i386? Doesn't CONFIG_XEN also control
here if the arch is xen-capable?

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux