[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 14/22] migration: Remove get_status() accessor
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 14/22] migration: Remove get_status() accessor |
Date: |
Wed, 23 Feb 2011 10:18:43 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
Yoshiaki Tamura <address@hidden> wrote:
> 2011/2/23 Juan Quintela <address@hidden>:
>> It is only used inside migration.c, and fields on that struct are
>> accessed all around the place on that file.
>
> I agree to access s->state directly inside of migration.c, but I
> disagree to remove get_status() accessor right away. We don't
> have strong motivations for doing that AFAIK.
Only user outside of migration.c was ui/spice-core.c, and it just wanted
to know if migration has finished at all.
At this point I was trying to isolate what other parts of MigrationState
are used externally. That way, it gets easier to change that later.
At this point, only things used outside of migration.c are:
- write, clase, get_error: trivial to fix, just add setters for them.
- fd: that is not enterely trivial to fix.
Later, Juan.
- Re: [Qemu-devel] [PATCH 10/22] migration: Refactor and simplify error checking in migrate_fd_put_ready, (continued)
[Qemu-devel] [PATCH 11/22] migration: Introduce migrate_fd_completed() for consistenncy, Juan Quintela, 2011/02/22
[Qemu-devel] [PATCH 12/22] migration: Use migrate_fd_error() in last place that set status to ERROR, Juan Quintela, 2011/02/22
[Qemu-devel] [PATCH 13/22] migration: Our release callback was just free, Juan Quintela, 2011/02/22
[Qemu-devel] [PATCH 15/22] migration: Remove migration cancel() callback, Juan Quintela, 2011/02/22
[Qemu-devel] [PATCH 14/22] migration: Remove get_status() accessor, Juan Quintela, 2011/02/22
[Qemu-devel] [PATCH 16/22] migration: Move exported functions to the end of the file, Juan Quintela, 2011/02/22
[Qemu-devel] [PATCH 17/22] migration: use global variable directly, Juan Quintela, 2011/02/22
[Qemu-devel] [PATCH 18/22] migration: another case of global variable assigned to local one, Juan Quintela, 2011/02/22
[Qemu-devel] [PATCH 19/22] migration: convert current_migration from pointer to struct, Juan Quintela, 2011/02/22
[Qemu-devel] [PATCH 21/22] migration: Export a function that tells if the migration has finished correctly, Juan Quintela, 2011/02/22