[Qemu-devel] Re: [PATCH 03/22] migration: Fold MigrationState into FdMigrationState

[Juan Quintela]

Yoshiaki Tamura <address@hidden> wrote:
> 2011/2/23 Juan Quintela <address@hidden>:

>>  struct FdMigrationState
>>  {
>> -    MigrationState mig_state;
>>     int64_t bandwidth_limit;
>>     QEMUFile *file;
>>     int fd;
>> @@ -48,7 +35,12 @@ struct FdMigrationState
>>     int (*get_error)(struct FdMigrationState*);
>>     int (*close)(struct FdMigrationState*);
>>     int (*write)(struct FdMigrationState*, const void *, size_t);
>> +    void (*cancel)(FdMigrationState *s);
>> +    int (*get_status)(FdMigrationState *s);
>> +    void (*release)(FdMigrationState *s);
>>     void *opaque;
>> +    int blk;
>> +    int shared;
>>  };
>
> Although I don't have objections for folding MigrationState into
> FdMigrationState, it would be good to ask why the original author
> split it intentionally.

I asked, Anthony answer was that it is a "historical" artifact.

Later, Juan.