Re: [Qemu-devel] [PATCH 5/5] target-arm: fix support for VRSQRTE.

[Peter Maydell]

On 21 February 2011 10:59, Christophe Lyon <address@hidden> wrote:
> +    if (float32_is_any_nan(a)) {
> +        if (float32_is_signaling_nan(a)) {
> +            float_raise(float_flag_invalid, s);
> +        }
> +        return float32_maybe_silence_nan(a);

Wrong answer for NaNs, fix as per comments in other patch.

> +    if ((a & 0xc0000000) == 0) return 0xffffffff;

if (cond) {
    return thing;
}

please, as per coding style. (Sorry, should have spotted
that in the review pass for earlier versions.)

-- PMM