[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] target-arm: fix Neon VUZP, VZIP instruct
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] target-arm: fix Neon VUZP, VZIP instructions |
Date: |
Sun, 20 Feb 2011 17:35:58 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Mon, Feb 14, 2011 at 10:22:47AM +0000, Peter Maydell wrote:
> This patch series fixes bugs in the Neon VZIP and VUZP instructions
> by abandoning the existing inline implementations in favour of
> calling out to straightforward helper functions. The inline routines
> could generate 50+ TCG ops each, which is well over the recommended
> limit in tcg/README for using helpers instead; they also did
> not give the correct results...
>
> I've tested these patches using the usual random instruction
> generation approach.
>
> V2 changes: moved the decoding of register numbers, size and q
> flag out of the helper functions into translate.c; split the
> helpers up into one per (size, q) combination.
>
> Peter Maydell (2):
> target-arm: Move Neon VUZP to helper functions
> target-arm: Move Neon VZIP to helper functions
>
> target-arm/helpers.h | 11 +++
> target-arm/neon_helper.c | 186 +++++++++++++++++++++++++++++++++++++++
> target-arm/translate.c | 215
> +++++++++++++++-------------------------------
> 3 files changed, 267 insertions(+), 145 deletions(-)
>
Thanks, both applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net