[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 09/13] kvm: x86: Consolidate TCG and KVM MCE inj
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 09/13] kvm: x86: Consolidate TCG and KVM MCE injection code |
Date: |
Thu, 17 Feb 2011 19:17:04 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-02-17 19:08, Marcelo Tosatti wrote:
> On Tue, Feb 15, 2011 at 09:23:33AM +0100, Jan Kiszka wrote:
>> This switches KVM's MCE injection path to cpu_x86_inject_mce, both for
>> SIGBUS and monitor initiated events. This means we prepare the MCA MSRs
>> in the VCPUState also for KVM.
>>
>> We have to drop the MSRs writeback restrictions for this purpose which
>> is now safe as every uncoordinated MSR injection is removed with this
>> patch.
>>
>> We have to execute every per-VCPU event setup on the target VCPU as we
>> are performing a read-modify-write on its state.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> CC: Huang Ying <address@hidden>
>> CC: Hidetoshi Seto <address@hidden>
>> CC: Jin Dongming <address@hidden>
>
> Difficult to review, please split:
>
> - drop writeback restriction
That will not work due to mutual dependency (see changelog)...
> - unify monitor/sigbus injection paths
> - cleanup / refactor
>
...but I will check again and filter out potential cleanups that could
be done afterwards.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- [Qemu-devel] [PATCH 05/13] x86: Optionally avoid injecting AO MCEs while others are pending, (continued)
[Qemu-devel] [PATCH 13/13] KVM, MCE, unpoison memory address across reboot, Jan Kiszka, 2011/02/15
[Qemu-devel] [PATCH 09/13] kvm: x86: Consolidate TCG and KVM MCE injection code, Jan Kiszka, 2011/02/15
[Qemu-devel] [PATCH 04/13] x86: Refine error reporting of MCE injection services, Jan Kiszka, 2011/02/15