[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH REBASE/RESEND 2/4] virtio-serial: Add descriptio
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH REBASE/RESEND 2/4] virtio-serial: Add description fields for qdev properties |
Date: |
Thu, 17 Feb 2011 18:33:24 +0530 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On (Tue) 15 Feb 2011 [10:10:23], Anthony Liguori wrote:
> >diff --git a/hw/virtio-serial.h b/hw/virtio-serial.h
> >index a308196..2c5e336 100644
> >--- a/hw/virtio-serial.h
> >+++ b/hw/virtio-serial.h
> >@@ -57,6 +57,19 @@ struct virtio_console_control {
> >
> > /* == In-qemu interface == */
> >
> >+#define PROP_VIRTSERIAL_IS_CONSOLE_DESC \
> >+ "An hvc console will be spawned in the guest if this is set."
> >+
> >+#define PROP_VIRTSERIAL_NR_DESC \
> >+ "The 'number' for the port for predictable port numbers. Use this to " \
> >+ "spawn ports if you plan to migrate the guest."
> >+
> >+#define PROP_VIRTSERIAL_CHR_DESC \
> >+ "The chardev to associate this port with."
> >+
> >+#define PROP_VIRTSERIAL_NAME_DESC \
> >+ "Name for the port that's exposed to the guest for port discovery."
> >+
>
> Why are you using a #define instead of inlining the docs?
These are shared by the generic and console ports.
Amit
[Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Amit Shah, 2011/02/04
- Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Anthony Liguori, 2011/02/15
- Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Amit Shah, 2011/02/17
- Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Anthony Liguori, 2011/02/17
- Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Amit Shah, 2011/02/17
- Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Markus Armbruster, 2011/02/18
- Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Anthony Liguori, 2011/02/18
Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Markus Armbruster, 2011/02/18