Re: [Qemu-devel] [PATCH] uninit drive if drive_init failed

[Markus Armbruster]

Wen Congyang <address@hidden> writes:

> steps to reproduce this bug:
> 1. virsh attach-disk domain --source imagefile --target sdb --sourcetype file 
> --driver qemu --subdriver qcow2
> error: Failed to attach disk
> error: operation failed: adding 
> scsi-disk,bus=scsi0.0,scsi-id=1,drive=drive-scsi0-0-1,id=scsi0-0-1 device 
> failed: Property 'scsi-disk.drive' can't find value 'drive-scsi0-0-1'
>
> 2. virsh attach-disk domain --source imagefile --target sdb --sourcetype file 
> --driver qemu --subdriver raw
> error: Failed to attach disk
> error: operation failed: adding 
> scsi-disk,bus=scsi0.0,scsi-id=1,drive=drive-scsi0-0-1,id=scsi0-0-1 device 
> failed: Property 'scsi-disk.drive' can't find value 'drive-scsi0-0-1'
>
> The format of disk image file is raw.
> If we run comand 2 only, we will attach the disk successfully.
>
> The reason of this bug is that: we do not remove dinfo from drives and 
> dinfo->bdrv from bdrv_states
> if we open the disk image file failed.
>
> Signed-off-by: Wen Congyang <address@hidden>

Already fixed in Kevin's block tree and 0.14-rc2 (commit 08931947),
although not yet in stable.

Thanks anyway!