[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 09/15] Parse SDR1 on mtspr instead of at tra
|
From: |
David Gibson |
|
Subject: |
Re: [Qemu-devel] Re: [PATCH 09/15] Parse SDR1 on mtspr instead of at translate time |
|
Date: |
Sun, 13 Feb 2011 20:02:31 +1100 |
|
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Sat, Feb 12, 2011 at 04:37:46PM +0100, Alexander Graf wrote:
> On 12.02.2011, at 15:54, David Gibson wrote:
[snip]
> > +#define SDR_HTABORG_32 0xFFFF0000UL
> > +#define SDR_HTABMASK 0x000001FFUL
>
> Please mark this constant as ppc32
>
> > +
> > +#if defined(TARGET_PPC64)
> > +#define SDR_HTABORG_64 0xFFFFFFFFFFFC0000ULL
> > +#define SDR_HTABSIZE 0x000000000000001FULL
>
> Please mark this constant as ppc64
Um.. I'm not sure what you mean by this.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
- [Qemu-devel] [PATCH 06/15] Implement missing parts of the logic for the POWER PURR, (continued)
- [Qemu-devel] [PATCH 06/15] Implement missing parts of the logic for the POWER PURR, David Gibson, 2011/02/12
- [Qemu-devel] [PATCH 07/15] Correct ppc popcntb logic, implement popcntw and popcntd, David Gibson, 2011/02/12
- [Qemu-devel] [PATCH 10/15] Use "hash" more consistently in ppc mmu code, David Gibson, 2011/02/12
- [Qemu-devel] [PATCH 11/15] Better factor the ppc hash translation path, David Gibson, 2011/02/12
- [Qemu-devel] [PATCH 09/15] Parse SDR1 on mtspr instead of at translate time, David Gibson, 2011/02/12
[Qemu-devel] [PATCH 05/15] Implement PowerPC slbmfee and slbmfev instructions, David Gibson, 2011/02/12
[Qemu-devel] [PATCH 12/15] Support 1T segments on ppc, David Gibson, 2011/02/12