Re: [Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

[Christophe Lyon]

On 08.02.2011 16:59, Peter Maydell wrote:
> Your subject is a bit long, which can make it wrap annoyingly in git logs.
> I'd suggest something like:
OK.

 

> This is float32_to_float16() but it looks like you've missed
> float16_to_float32() ?

Well, actually I somewhat managed to persuade myself that it was not necessary 
to patch float16_to_float32(), but looking at it again it seems there are more 
bugs in that function:
- the ieee parameter shouldn't be used (my ARM ARM does not mention a different 
behaviour when AH bit is set)
- it calls float32ToCommonNaN(a) where 'a' is a float16 instead of a float32
- this means implementing float16ToCommonNaN, thus float16_is_signaling_nan()

> 
> Otherwise, looks good, and I can confirm that it fixes
> behaviour of VCVT.F32.F64 and VCVT.F64.F32 when
> the FPSCR.DN bit is set.

Thanks for the confirmation.

Christophe.