|
| From: | Jan Kiszka |
| Subject: | Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift |
| Date: | Mon, 07 Feb 2011 16:20:40 +0100 |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-02-07 16:13, Avi Kivity wrote: >> >> PeriodicTimer *periodic_timer_new(PeriodicTimerFunc *cb, void *opaque); >> > > void periodic_timer_init(PeriodicTimer *timer, PeriodicTimerFunc *cb); > > It is better to embed than to reference. And embedding means making the layout (at least the size) of PeriodicTimer public. I guess that's why QEMUTimer works via new. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
| [Prev in Thread] | Current Thread | [Next in Thread] |