[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [STABLE 0.14][PATCH 03/14] block/vdi: Fix wrong size in con
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [STABLE 0.14][PATCH 03/14] block/vdi: Fix wrong size in conditionally used memset, memcmp |
Date: |
Mon, 7 Feb 2011 13:46:25 +0100 |
From: Stefan Weil <address@hidden>
Error report from cppcheck:
block/vdi.c:122: error: Using sizeof for array given as function argument
returns the size of pointer.
block/vdi.c:128: error: Using sizeof for array given as function argument
returns the size of pointer.
Fix both by setting the correct size.
The buggy code is only used when QEMU is build without uuid support.
The bug is not critical, so there is no urgent need to apply it to
old versions of QEMU.
Cc: Kevin Wolf <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
(cherry picked from commit 4f3669ea5bd73ade0dce5f1155cb9ad9788fd54c)
---
block/vdi.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/vdi.c b/block/vdi.c
index ab8f70f..116b25b 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -119,13 +119,13 @@ void uuid_unparse(const uuid_t uu, char *out);
#if !defined(CONFIG_UUID)
void uuid_generate(uuid_t out)
{
- memset(out, 0, sizeof(out));
+ memset(out, 0, sizeof(uuid_t));
}
int uuid_is_null(const uuid_t uu)
{
uuid_t null_uuid = { 0 };
- return memcmp(uu, null_uuid, sizeof(uu)) == 0;
+ return memcmp(uu, null_uuid, sizeof(uuid_t)) == 0;
}
void uuid_unparse(const uuid_t uu, char *out)
--
1.7.2.3
- [Qemu-devel] [STABLE 0.14][PULL 00/14] Block patches for stable-0.14, Kevin Wolf, 2011/02/07
- [Qemu-devel] [STABLE 0.14][PATCH 01/14] qcow2: Really use cache=unsafe for image creation, Kevin Wolf, 2011/02/07
- [Qemu-devel] [STABLE 0.14][PATCH 02/14] Documentation: add Sheepdog disk images, Kevin Wolf, 2011/02/07
- [Qemu-devel] [STABLE 0.14][PATCH 08/14] ahci: Implement HBA reset, Kevin Wolf, 2011/02/07
- [Qemu-devel] [STABLE 0.14][PATCH 05/14] ahci: add license header in ahci.h, Kevin Wolf, 2011/02/07
- [Qemu-devel] [STABLE 0.14][PATCH 04/14] ahci: split ICH9 from core, Kevin Wolf, 2011/02/07
- [Qemu-devel] [STABLE 0.14][PATCH 06/14] ahci: split ICH and AHCI even more, Kevin Wolf, 2011/02/07
- [Qemu-devel] [STABLE 0.14][PATCH 03/14] block/vdi: Fix wrong size in conditionally used memset, memcmp,
Kevin Wolf <=
- [Qemu-devel] [STABLE 0.14][PATCH 07/14] ahci: send init d2h fis on fis enable, Kevin Wolf, 2011/02/07
- [Qemu-devel] [STABLE 0.14][PATCH 10/14] block-migration: actually disable dirty tracking on cleanup, Kevin Wolf, 2011/02/07
- [Qemu-devel] [STABLE 0.14][PATCH 12/14] block-migration: add reference to target DriveInfo, Kevin Wolf, 2011/02/07
- [Qemu-devel] [STABLE 0.14][PATCH 11/14] blockdev: add refcount to DriveInfo, Kevin Wolf, 2011/02/07
- [Qemu-devel] [STABLE 0.14][PATCH 09/14] ahci: make number of ports runtime determined, Kevin Wolf, 2011/02/07
- [Qemu-devel] [STABLE 0.14][PATCH 13/14] Add flag to indicate external users to block device, Kevin Wolf, 2011/02/07
- [Qemu-devel] [STABLE 0.14][PATCH 14/14] block: enable in_use flag, Kevin Wolf, 2011/02/07