[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 09/15] kvm: Drop return values from kvm_arch_pre/pos
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [PATCH 09/15] kvm: Drop return values from kvm_arch_pre/post_run |
Date: |
Mon, 7 Feb 2011 12:19:20 +0100 |
We do not check them, and the only arch with non-empty implementations
always returns 0 (this is also true for qemu-kvm).
Signed-off-by: Jan Kiszka <address@hidden>
CC: Alexander Graf <address@hidden>
---
kvm.h | 5 ++---
target-i386/kvm.c | 8 ++------
target-ppc/kvm.c | 6 ++----
target-s390x/kvm.c | 6 ++----
4 files changed, 8 insertions(+), 17 deletions(-)
diff --git a/kvm.h b/kvm.h
index b2fb5c6..7a4d550 100644
--- a/kvm.h
+++ b/kvm.h
@@ -99,12 +99,11 @@ int kvm_vcpu_ioctl(CPUState *env, int type, ...);
extern const KVMCapabilityInfo kvm_arch_required_capabilities[];
-int kvm_arch_post_run(CPUState *env, struct kvm_run *run);
+void kvm_arch_pre_run(CPUState *env, struct kvm_run *run);
+void kvm_arch_post_run(CPUState *env, struct kvm_run *run);
int kvm_arch_handle_exit(CPUState *env, struct kvm_run *run);
-int kvm_arch_pre_run(CPUState *env, struct kvm_run *run);
-
int kvm_arch_process_irqchip_events(CPUState *env);
int kvm_arch_get_registers(CPUState *env);
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index f02f478..8668cb3 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -1440,7 +1440,7 @@ int kvm_arch_get_registers(CPUState *env)
return 0;
}
-int kvm_arch_pre_run(CPUState *env, struct kvm_run *run)
+void kvm_arch_pre_run(CPUState *env, struct kvm_run *run)
{
/* Inject NMI */
if (env->interrupt_request & CPU_INTERRUPT_NMI) {
@@ -1486,11 +1486,9 @@ int kvm_arch_pre_run(CPUState *env, struct kvm_run *run)
DPRINTF("setting tpr\n");
run->cr8 = cpu_get_apic_tpr(env->apic_state);
}
-
- return 0;
}
-int kvm_arch_post_run(CPUState *env, struct kvm_run *run)
+void kvm_arch_post_run(CPUState *env, struct kvm_run *run)
{
if (run->if_flag) {
env->eflags |= IF_MASK;
@@ -1499,8 +1497,6 @@ int kvm_arch_post_run(CPUState *env, struct kvm_run *run)
}
cpu_set_apic_tpr(env->apic_state, run->cr8);
cpu_set_apic_base(env->apic_state, run->apic_base);
-
- return 0;
}
int kvm_arch_process_irqchip_events(CPUState *env)
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index 93ecc57..bd4012a 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -256,14 +256,12 @@ int kvm_arch_pre_run(CPUState *env, struct kvm_run *run)
return 0;
}
-int kvm_arch_post_run(CPUState *env, struct kvm_run *run)
+void kvm_arch_post_run(CPUState *env, struct kvm_run *run)
{
- return 0;
}
-int kvm_arch_process_irqchip_events(CPUState *env)
+void kvm_arch_process_irqchip_events(CPUState *env)
{
- return 0;
}
static int kvmppc_handle_halt(CPUState *env)
diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index 1702c46..b349812 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -169,14 +169,12 @@ int kvm_arch_remove_sw_breakpoint(CPUState *env, struct
kvm_sw_breakpoint *bp)
return 0;
}
-int kvm_arch_pre_run(CPUState *env, struct kvm_run *run)
+void kvm_arch_pre_run(CPUState *env, struct kvm_run *run)
{
- return 0;
}
-int kvm_arch_post_run(CPUState *env, struct kvm_run *run)
+void kvm_arch_post_run(CPUState *env, struct kvm_run *run)
{
- return 0;
}
int kvm_arch_process_irqchip_events(CPUState *env)
--
1.7.1
- [Qemu-devel] [PATCH 07/15] kvm: Separate TCG from KVM cpu execution, (continued)
[Qemu-devel] [PATCH 05/15] Refactor debug and vmstop request interface, Jan Kiszka, 2011/02/07
[Qemu-devel] [PATCH 10/15] kvm: x86: Catch and report failing IRQ and NMI injections, Jan Kiszka, 2011/02/07
[Qemu-devel] [PATCH 03/15] Fix a few coding style violations in cpus.c, Jan Kiszka, 2011/02/07
[Qemu-devel] [PATCH 01/15] Refactor kvm&tcg function names in cpus.c, Jan Kiszka, 2011/02/07
[Qemu-devel] [PATCH 08/15] kvm: x86: Prepare VCPU loop for in-kernel irqchip, Jan Kiszka, 2011/02/07
[Qemu-devel] [PATCH 09/15] kvm: Drop return values from kvm_arch_pre/post_run,
Jan Kiszka <=
[Qemu-devel] [PATCH 04/15] Improve vm_stop reason declarations, Jan Kiszka, 2011/02/07
[Qemu-devel] [PATCH v2 04/15] Improve vm_stop reason declarations, Jan Kiszka, 2011/02/09
[Qemu-devel] [PATCH 12/15] Introduce log_start/log_stop in CPUPhysMemoryClient, Jan Kiszka, 2011/02/07
[Qemu-devel] [PATCH 06/15] Move debug exception handling out of cpu_exec, Jan Kiszka, 2011/02/07