[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pcibus_get_dev_path: correct pci device path co
From: |
Igor Kovalenko |
Subject: |
Re: [Qemu-devel] [PATCH] pcibus_get_dev_path: correct pci device path construction |
Date: |
Mon, 31 Jan 2011 22:01:25 +0300 |
On Mon, Jan 31, 2011 at 5:56 PM, Mark Cave-Ayland
<address@hidden> wrote:
> On 18/01/11 21:10, Igor V. Kovalenko wrote:
>
>> From: Igor V. Kovalenko<address@hidden>
>>
>> - fix snprintf off by one
>> pci domain and slot number formatting snprintf calls
>> require extra space for trailing null character
>>
>> without this change devices are assigned the same path name
>> which triggers assertion in vmstate_register_with_alias_id
>>
>> - while iterating over devices from root pci device
>> use PCI_SLOT and PCI_FUNC of each device on the path
>> instead of always extracting PCI_FUNC of original device
>>
>> Signed-off-by: Igor V. Kovalenko<address@hidden>
>> ---
>> hw/pci.c | 28 ++++++++++++++++++++--------
>> 1 files changed, 20 insertions(+), 8 deletions(-)
>>
>
> Has anyone had a chance to look at this patch yet?
>
The issue is already fixed in the tree differently by
commits e10990c3f0c39e92ab5f74004b89a24fcc36fa14
and 2991181aaa026d8b1444bfaa9c4bcd82065ba5a3
--
Kind regards,
Igor V. Kovalenko