qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/8] make -qmp stdio usable


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 0/8] make -qmp stdio usable
Date: Fri, 28 Jan 2011 13:59:41 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

> This patch series is a rewritten version of the patch to disable
> raw mode on the terminal when "-qmp stdio" is given on the command-line.
>
> The rewritten series has several advantages, including working for
> text consoles ("-qmp vc2") and especially working with -chardev/-mon
> without the need to add special options.  This is because in this
> series it is _the monitor_ who asks to disable raw mode.
>
> Patch 2 adds a new CharDriverState method.  Patches 3/4 implement
> it for stdio, while patches 5/6 implement it for text consoles.
>
> Patches 1, 7 and 8 are related cleanups.

Series looks sane to me.  However, I'm not really qualified to pass
judgement on PATCH 5+6.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]