[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/3] check-qdict: Fix possible crash
From: |
Stefan Weil |
Subject: |
[Qemu-devel] [PATCH 2/3] check-qdict: Fix possible crash |
Date: |
Fri, 21 Jan 2011 22:50:30 +0100 |
This warning is reported by cppcheck:
check-qdict.c:270: warning: scanf without field width limits can crash with
huge input data
Fix it by limiting the field widths to 127 (both key and value take
127 characters + a terminating '\0' byte).
Signed-off-by: Stefan Weil <address@hidden>
---
check-qdict.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/check-qdict.c b/check-qdict.c
index 6afce5a..ecc7fd7 100644
--- a/check-qdict.c
+++ b/check-qdict.c
@@ -267,8 +267,9 @@ static QString *read_line(FILE *file, char *key)
{
char value[128];
- if (fscanf(file, "%s%s", key, value) == EOF)
+ if (fscanf(file, "%127s%127s", key, value) == EOF) {
return NULL;
+ }
remove_dots(key);
return qstring_from_str(value);
}
--
1.7.2.3
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH 2/3] check-qdict: Fix possible crash,
Stefan Weil <=