Re: [Qemu-devel] [PATCH] linux-user: Fix possible realloc memory leak

[Stefan Weil]

Am 18.01.2011 09:26, schrieb Markus Armbruster:
> Stefan Weil <address@hidden> writes:
>
> > Extract from "man realloc":
> > "If realloc() fails the original block is left untouched;
> > it is not freed or moved."
> >
> > Fix a possible memory leak (reported by cppcheck).
> >
> > Cc: Riku Voipio <address@hidden>
> > Signed-off-by: Stefan Weil <address@hidden>
>
> Sidestep the problem via qemu_realloc() instead?

The same change was applied to bsd-user/elfload.c.

As symbol loading is not essential in most applications,
returning after out-of-memory should be better than
aborting (that's what qemu_realloc does).