[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/5] blockdev: Fix error message for invalid -drive
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 1/5] blockdev: Fix error message for invalid -drive CHS |
Date: |
Mon, 17 Jan 2011 19:31:26 +0100 |
When cyls, heads or secs are out of range, the error message prints
buf, which points to the value of option "if". Bogus, may even be
null. Drop that.
Signed-off-by: Markus Armbruster <address@hidden>
---
blockdev.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index d7add36..b01a87c 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -224,15 +224,15 @@ DriveInfo *drive_init(QemuOpts *opts, int
default_to_scsi, int *fatal_error)
if (cyls || heads || secs) {
if (cyls < 1 || (type == IF_IDE && cyls > 16383)) {
- fprintf(stderr, "qemu: '%s' invalid physical cyls number\n", buf);
+ fprintf(stderr, "qemu: invalid physical cyls number\n");
return NULL;
}
if (heads < 1 || (type == IF_IDE && heads > 16)) {
- fprintf(stderr, "qemu: '%s' invalid physical heads number\n", buf);
+ fprintf(stderr, "qemu: invalid physical heads number\n");
return NULL;
}
if (secs < 1 || (type == IF_IDE && secs > 63)) {
- fprintf(stderr, "qemu: '%s' invalid physical secs number\n", buf);
+ fprintf(stderr, "qemu: invalid physical secs number\n");
return NULL;
}
}
--
1.7.2.3
- [Qemu-devel] [PATCH 0/5] -drive/drive_add fixes, Markus Armbruster, 2011/01/17
- [Qemu-devel] [PATCH 1/5] blockdev: Fix error message for invalid -drive CHS,
Markus Armbruster <=
- [Qemu-devel] [PATCH 4/5] blockdev: Fix drive_del not to crash when drive is not in use, Markus Armbruster, 2011/01/17
- [Qemu-devel] [PATCH 3/5] blockdev: Reject multiple definitions for the same drive, Markus Armbruster, 2011/01/17
- [Qemu-devel] Re: [PATCH 3/5] blockdev: Reject multiple definitions for the same drive, Kevin Wolf, 2011/01/21
- [Qemu-devel] Re: [PATCH 3/5] blockdev: Reject multiple definitions for the same drive, Markus Armbruster, 2011/01/21
- [Qemu-devel] Re: [PATCH 3/5] blockdev: Reject multiple definitions for the same drive, Kevin Wolf, 2011/01/21
- [Qemu-devel] Re: [PATCH 3/5] blockdev: Reject multiple definitions for the same drive, Markus Armbruster, 2011/01/21
- [Qemu-devel] Re: [PATCH 3/5] blockdev: Reject multiple definitions for the same drive, Kevin Wolf, 2011/01/21
- [Qemu-devel] Re: [PATCH 3/5] blockdev: Reject multiple definitions for the same drive, Markus Armbruster, 2011/01/24
[Qemu-devel] [PATCH 2/5] blockdev: Make drive_init() use error_report(), Markus Armbruster, 2011/01/17
[Qemu-devel] [PATCH 5/5] blockdev: Fix drive_add for drives without media, Markus Armbruster, 2011/01/17