[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/4] piix: tag as not hotpluggable.
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/4] piix: tag as not hotpluggable. |
Date: |
Wed, 12 Jan 2011 13:22:06 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Gerd Hoffmann <address@hidden> writes:
> This patch tags all pci devices which belong to the piix3/4 chipsets as
> not hotpluggable (Host bridge, ISA bridge, IDE controller, ACPI bridge).
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/acpi_piix4.c | 2 ++
> hw/ide/piix.c | 2 ++
> hw/piix4.c | 1 +
> hw/piix_pci.c | 2 ++
> 4 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
> index 173d781..273097d 100644
> --- a/hw/acpi_piix4.c
> +++ b/hw/acpi_piix4.c
> @@ -428,6 +428,8 @@ static PCIDeviceInfo piix4_pm_info = {
> .qdev.desc = "PM",
> .qdev.size = sizeof(PIIX4PMState),
> .qdev.vmsd = &vmstate_acpi,
> + .qdev.no_user = 1,
Makes sense, but the commit message doesn't mention it.
> + .no_hotplug = 1,
> .init = piix4_pm_initfn,
> .config_write = pm_write_config,
> .qdev.props = (Property[]) {
> diff --git a/hw/ide/piix.c b/hw/ide/piix.c
> index 1cad906..d4289af 100644
> --- a/hw/ide/piix.c
> +++ b/hw/ide/piix.c
> @@ -194,11 +194,13 @@ static PCIDeviceInfo piix_ide_info[] = {
> .qdev.name = "piix3-ide",
> .qdev.size = sizeof(PCIIDEState),
> .qdev.no_user = 1,
> + .no_hotplug = 1,
> .init = pci_piix3_ide_initfn,
> },{
> .qdev.name = "piix4-ide",
> .qdev.size = sizeof(PCIIDEState),
> .qdev.no_user = 1,
> + .no_hotplug = 1,
> .init = pci_piix4_ide_initfn,
> },{
> /* end of list */
> diff --git a/hw/piix4.c b/hw/piix4.c
> index 5489386..72073cd 100644
> --- a/hw/piix4.c
> +++ b/hw/piix4.c
> @@ -113,6 +113,7 @@ static PCIDeviceInfo piix4_info[] = {
> .qdev.desc = "ISA bridge",
> .qdev.size = sizeof(PCIDevice),
> .qdev.no_user = 1,
> + .no_hotplug = 1,
> .init = piix4_initfn,
> },{
> /* end of list */
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 38f9d9e..358da58 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -348,6 +348,7 @@ static PCIDeviceInfo i440fx_info[] = {
> .qdev.size = sizeof(PCII440FXState),
> .qdev.vmsd = &vmstate_i440fx,
> .qdev.no_user = 1,
> + .no_hotplug = 1,
> .init = i440fx_initfn,
> .config_write = i440fx_write_config,
> },{
> @@ -356,6 +357,7 @@ static PCIDeviceInfo i440fx_info[] = {
> .qdev.size = sizeof(PIIX3State),
> .qdev.vmsd = &vmstate_piix3,
> .qdev.no_user = 1,
> + .no_hotplug = 1,
> .init = piix3_initfn,
> },{
> /* end of list */
What about "piix3-usb-uhci" & friends?