Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

[Avi Kivity]

On 01/11/2011 06:26 PM, Anthony Liguori wrote:
> > Visible, yes, but not in live migration, or in 'info i8254', or 
> > similar.  We can live migrate between qcow2 and qed (using block 
> > migration), we should be able to do the same for the two i8254 
> > implementations.
> >
> > I'm not happy about separate implementations, but that's a minor 
> > details.  We can change it 2n+1 times without anybody noticing.  Not 
> > so about ABI stuff.
> >
> > > Imagine getting a sosreport that includes a dump of the device 
> > > tree.  You really want to see something in there that tells you it's 
> > > an in-kernel PIT and not the userspace one.
> >
> > Sure.  Not the device tree though.  The command line would give all 
> > the information?
>
> Then it's a one off option.  We really want as much info as possible 
> stored in the device tree.
>
> > Or 'info i8254' can say something about the implementation.  I don't 
> > want to have the user say 'info i8254-kvm'.
>
> info doesn't take a qdev device so yes, it can show whatever we want 
> it to show.

It may be a qdev read-only attribute (and thus not migrated?) if we have 
to have it in qdev for some reason.