[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/5] char: Introduce char_set/remove_fd_handlers
From: |
Amit Shah |
Subject: |
[Qemu-devel] Re: [PATCH 2/5] char: Introduce char_set/remove_fd_handlers() |
Date: |
Tue, 11 Jan 2011 21:08:18 +0530 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On (Tue) Jan 11 2011 [15:39:46], Gerd Hoffmann wrote:
> On 01/11/11 12:10, Amit Shah wrote:
> >Introduce a char-specific wrapper to qemu_set_fd_handler functions.
> >This wrapper is useful to add / remove a write handler easily. Write
> >handlers are only used when the backend is blocked and cannot receive
> >any more input.
>
> I'd suggest to add flags to enable/disable handlers to
> IOHandlerRecord instead. And helper functions to set/clear them of
> course.
>
> With that in place you also can move the handlers to a separate
> struct simliar to the new QemuChrHandlers struct from patch #1.
I'm planning to do that later -- when more backends get involved, which
have multiple fds (one for in, one for out).
Are you OK with this for now (to solve the immediate bugs of guests
freezing if host can't flush data) and doing this cleanup later as we
progress?
Amit
- [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers, (continued)
- [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers, Amit Shah, 2011/01/11
- [Qemu-devel] Re: [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers, Gerd Hoffmann, 2011/01/11
- Re: [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers, Blue Swirl, 2011/01/11
- Re: [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers, Amit Shah, 2011/01/12
- Re: [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers, Michael Roth, 2011/01/12
- Re: [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers, Blue Swirl, 2011/01/12
- Re: [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers, Amit Shah, 2011/01/13
- Re: [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers, Blue Swirl, 2011/01/13
[Qemu-devel] [PATCH 2/5] char: Introduce char_set/remove_fd_handlers(), Amit Shah, 2011/01/11
[Qemu-devel] [PATCH 3/5] char: Add framework for a 'write unblocked' callback, Amit Shah, 2011/01/11
[Qemu-devel] [PATCH 4/5] char: Update send_all() to handle nonblocking chardev write requests, Amit Shah, 2011/01/11
[Qemu-devel] [PATCH 5/5] char: Equip the unix/tcp backend to handle nonblocking writes, Amit Shah, 2011/01/11