Re: [Qemu-devel] [PATCH] qdev: Fix printout of bit device properties with bit index >= 8

[Markus Armbruster]

address@hidden writes:

> From: David 'Digit' Turner <address@hidden>
>
> Signed-off-by: David 'Digit' Turner <address@hidden>
> ---
>  hw/qdev-properties.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
> index 9219cd7..d5d9591 100644
> --- a/hw/qdev-properties.c
> +++ b/hw/qdev-properties.c
> @@ -50,7 +50,7 @@ static int parse_bit(DeviceState *dev, Property *prop, 
> const char *str)
>  
>  static int print_bit(DeviceState *dev, Property *prop, char *dest, size_t 
> len)
>  {
> -    uint8_t *p = qdev_get_prop_ptr(dev, prop);
> +    uint32_t *p = qdev_get_prop_ptr(dev, prop);
>      return snprintf(dest, len, (*p & qdev_get_prop_mask(prop)) ? "on" : 
> "off");
>  }

Acked-by: Markus Armbruster <address@hidden>