|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state |
Date: | Mon, 10 Jan 2011 17:02:16 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Lightning/1.0b1 Thunderbird/3.0.10 |
On 01/10/2011 04:21 PM, Jan Kiszka wrote:
Am 10.01.2011 22:06, Jan Kiszka wrote:kvmclock should be created with kvm_state as a parameter and kvm_vm_ioctl() is passed the stored reference. Taking a global reference to kvm_state in machine_init is not a bad thing, obviously the machine initialization function needs access to the kvm_state.This would also require changing sysbus interfaces for the sake of KVM's "abstraction". If this is the only way forward, I could look into this.Actually, there is already a channel to pass pointers to qdev devices: the pointer property hack. I'm not sure we should contribute to its user base or take the chance for a cleanup, but we are not alone with this requirement. Point below remains valid, though.
It probably makes sense to have a KVMBus and not pass it as a property but rather have it access it from the KvmBusState.
Regards, Anthony Liguori
Still, I do not see any benefit for the affected code. You then either need to "steal" a kvm_state reference from the first cpu or introduce a marvelous interface like kvm_get_state() to make this work from outside of the KVM core.Jan
[Prev in Thread] | Current Thread | [Next in Thread] |