qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 6/7] lan9118: fix a buffer overflow


From: Blue Swirl
Subject: [Qemu-devel] [PATCH 6/7] lan9118: fix a buffer overflow
Date: Sat, 8 Jan 2011 18:25:21 +0000

Fix a buffer overflow, reported by cppcheck:
[/src/qemu/hw/lan9118.c:849]: (error) Buffer access out-of-bounds: s.eeprom

All eeprom handling code assumes that the size of eeprom is 128.

Signed-off-by: Blue Swirl <address@hidden>
---
 hw/lan9118.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/lan9118.c b/hw/lan9118.c
index a988664..1bb829e 100644
--- a/hw/lan9118.c
+++ b/hw/lan9118.c
@@ -187,7 +187,7 @@ typedef struct {
     uint32_t phy_int_mask;

     int eeprom_writable;
-    uint8_t eeprom[8];
+    uint8_t eeprom[128];

     int tx_fifo_size;
     LAN9118Packet *txp;
-- 
1.6.2.4



reply via email to

[Prev in Thread] Current Thread [Next in Thread]