[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-ppc: use float32_is_any_nan()
From: |
Nathan Froyd |
Subject: |
Re: [Qemu-devel] [PATCH] target-ppc: use float32_is_any_nan() |
Date: |
Wed, 5 Jan 2011 09:04:59 -0800 |
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
On Sun, Jan 02, 2011 at 01:06:49PM +0100, Aurelien Jarno wrote:
> Use the new function float32_is_any_nan() instead of
> float32_is_quiet_nan() || float32_is_signaling_nan().
>
> Cc: Alexander Graf <address@hidden>
> Signed-off-by: Aurelien Jarno <address@hidden>
Reviewed-by: Nathan Froyd <address@hidden>
> @@ -1938,7 +1938,7 @@ target_ulong helper_dlmzb (target_ulong high,
> target_ulong low, uint32_t update_
> /* If X is a NaN, store the corresponding QNaN into RESULT. Otherwise,
> * execute the following block. */
> #define DO_HANDLE_NAN(result, x) \
> - if (float32_is_quiet_nan(x) || float32_is_signaling_nan(x)) { \
> + if (float32_is_any_nan(x)) { \
> CPU_FloatU __f; \
> __f.f = x; \
> __f.l = __f.l | (1 << 22); /* Set QNaN bit. */ \
If you were looking for other cleanups, this could stand a
maybe_silence_nan.
-Nathan