Re: [Qemu-devel] [PATCH] cirrus_vga: fix division by 0 for color expansion rop

[Aurelien Jarno]

On Fri, Dec 31, 2010 at 08:11:18PM +0100, Aurelien Jarno wrote:
> Commit d85d0d3883f5a567fa2969a0396e42e0a662b3fa introduces a regression
> with Windows ME that leads to a division by 0 and a crash.
> 
> It uses the color expansion rop with the source pitch set to 0. This is
> something allowed, as the manual explicitely says "When the source of
> color-expand data is display memory, the source pitch is ignored.".
> 
> This patch fixes this regression by computing sx, sy and others
> variables only if they are going to be used later, that is for a plain
> copy ROP. It basically consists in moving code.
> 
> Signed-off-by: Aurelien Jarno <address@hidden>
> ---
>  hw/cirrus_vga.c |   65 
> ++++++++++++++++++++++++++++---------------------------
>  1 files changed, 33 insertions(+), 32 deletions(-)

I have just discovered that this patch fixes bug #604166:

https://bugs.launchpad.net/qemu/+bug/604166

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net