Re: [Qemu-devel] [PATCH] disable sigcld handling before calling pclose()

[Andreas Färber]

Am 20.12.2010 um 02:25 schrieb Wen Congyang:

> At 12/14/2010 05:23 PM, Wen Congyang Write:
> > At 2010-12-09 11:41, Wen Congyang Write:
> > > When I use the command 'virsh save' to save the domain state,
> > > I receive the following error message:
> > > operation failed: Migration unexpectedly failed.
> > >
> > > I debug the qemu by adding some printf(), and find the function
> > > pclose() returns -1.
> > >
> > > I use strace to trace qemu, the log is as the following:
> > > ======
> > > close(17)                               = 0
> > > --- SIGCHLD (Child exited) @ 0 (0) ---
> > > wait4(-1, NULL, WNOHANG, NULL)          = 22016
> > > rt_sigreturn(0)                         = 0
> > > wait4(22016, 0x7fff7f1034fc, 0, NULL)   = -1 ECHILD (No child  
> > > processes)
> > > ======
> > >
> > > We wait the child twice: one is in signal SIGCHLD handling and the  
> > > other
> > > one is in pclose().
> > >
> > > We should disable sigcld handling before calling pclose().
> > >
> > > Signed-off-by: Wen Congyang <address@hidden>
> > Ping :)
>
> Ping Again... :)

os-posix.c part looks sane to me, but what about Win32? Wouldn't it  
need stub functions?

Andreas