[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 3/3] Prevent creating an image with the same fil
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] Re: [PATCH 3/3] Prevent creating an image with the same filename as backing file |
Date: |
Thu, 16 Dec 2010 12:48:45 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
Am 16.12.2010 12:04, schrieb address@hidden:
> From: Jes Sorensen <address@hidden>
>
> Signed-off-by: Jes Sorensen <address@hidden>
> ---
> block.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/block.c b/block.c
> index 765f9f3..027dc6a 100644
> --- a/block.c
> +++ b/block.c
> @@ -2769,6 +2769,13 @@ int bdrv_img_create(const char *filename, const char
> *fmt,
> BlockDriver *drv, *proto_drv;
> int ret = 0;
>
> + if (!strcmp(filename, base_filename)) {
> + error_report("Error: Trying to create a snapshot with the same "
> + "filename as the backing file");
> + ret = -1;
> + goto out;
> + }
> +
> /* Find driver and parse its options */
> drv = bdrv_find_format(fmt);
> if (!drv) {
This doesn't catch things like qemu-img create -f qcow2
-obacking_file=foo.qcow2 foo.qcow2 though it will work if you use the
legacy -b option. I think we should keep it consistent.
Kevin