[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] qemu-img.c: Clean up handling of image size
|
From: |
Jes Sorensen |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] qemu-img.c: Clean up handling of image size in img_create() |
|
Date: |
Wed, 08 Dec 2010 10:14:20 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6 |
On 12/08/10 09:54, Kevin Wolf wrote:
> Am 07.12.2010 21:36, schrieb Stefan Hajnoczi:
>> Today it is possible to create 0 byte sized images. Your patch will
>> change that:
>> If there is a backing file, then the size will be taken from the backing
>> file.
>> If there is no backing file, then an error about missing size will be
>> printed, even though a size of 0 has been given.
>
> I can think of one use case for it: You can store the VM state on a
> zero-sized qcow2 image for internal snapshots.
>
> Otherwise it's probably rather useless, but we have supported it for a
> long time, so I wouldn't remove it. People have actually noticed in the
> past when something was broken with it.
Ok that is fair, I have just posted an updated version which should do
the right thing. Shows up it made the patch even simpler :)
Cheers,
Jes