[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH v5] virtio-9p: fix build on !CONFIG_UTIMENSA
From: |
Hidetoshi Seto |
Subject: |
Re: [Qemu-devel] Re: [PATCH v5] virtio-9p: fix build on !CONFIG_UTIMENSAT |
Date: |
Wed, 01 Dec 2010 10:16:15 +0900 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 6.0; ja; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 |
Ping.
Maintainers, please tell me if still something is required for
this patch before applying it.
Thanks,
H.Seto
(2010/11/24 17:01), Jes Sorensen wrote:
> On 11/24/10 03:38, Hidetoshi Seto wrote:
>> This patch introduce a fallback mechanism for old systems that do not
>> support utimensat(). This fix build failure with following warnings:
>>
>> hw/virtio-9p-local.c: In function 'local_utimensat':
>> hw/virtio-9p-local.c:479: warning: implicit declaration of function
>> 'utimensat'
>> hw/virtio-9p-local.c:479: warning: nested extern declaration of 'utimensat'
>>
>> and:
>>
>> hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod':
>> hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this
>> function)
>> hw/virtio-9p.c:1410: error: (Each undeclared identifier is reported only once
>> hw/virtio-9p.c:1410: error: for each function it appears in.)
>> hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this
>> function)
>> hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod':
>> hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this
>> function)
>>
>> [NOTE: At this time virtio-9p is only user of utimensat(), and is available
>> only when host is linux and CONFIG_VIRTFS is defined. So there are
>> no similar warning for win32. Please provide a wrapper for win32 in
>> oslib-win32.c if new user really requires it.]
>>
>> v5:
>> - Allow fallback on runtime
>> - Move qemu_utimensat() to oslib-posix.c
>> - Rebased on latest qemu.git
>> v4:
>> - Use tv_now.tv_usec
>> v3:
>> - Use better alternative handling for UTIME_NOW/OMIT
>> - Move qemu_utimensat() to cutils.c
>> V2:
>> - Introduce qemu_utimensat()
>>
>> Acked-by: Chris Wright <address@hidden>
>> Acked-by: M. Mohan Kumar <address@hidden>
>> Signed-off-by: Hidetoshi Seto <address@hidden>
>> ---
>> hw/virtio-9p-local.c | 4 ++--
>> oslib-posix.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>> qemu-os-posix.h | 12 ++++++++++++
>> 3 files changed, 62 insertions(+), 2 deletions(-)
>
> Hi Hidetoshi,
>
> This looks good to me!
>
> Acked-by: Jes Sorensen <address@hidden>
>
> Cheers,
> Jes