|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: [RfC PATCH] spice: qmp windup: connection events & info command. |
Date: | Mon, 29 Nov 2010 12:02:45 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat/3.1.3-1.el6 Thunderbird/3.1.3 |
Hi,
Doesn't make that much sense IMHO as the both provide quite simliar informations (i.e. "info spice" gives you a list of connections with pretty much the same info provided by the events).If you are wanting to record/log incoming connections, then you can't use 'info spice' to get the details, because between the time of getting the event notification of the new client and calling 'info spice' to get the client details, the client can have disconnected. Thus all the info needs to be provided in the event, even if it is also available in 'info spice'. This is the same as with VNC events.
Sure. All the info is given in both cases, thats why there is quite some code sharing ;) I'll go split the patch nevertheless, with the doc updates added it indeed makes sense.
"info spice" can be used to figure the connections which did already exist before management connected to qmp. Later on just processing the events gives you all informations you need.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |