Re: [Qemu-devel] [PATCH] scsi: Use 'SCSIRequest' directly

[Christoph Hellwig]

On Mon, Nov 22, 2010 at 11:15:35AM +0100, Hannes Reinecke wrote:
> 
> Currently the SCSIRequest structure is abstracted away and
> cannot accessed directly from the driver. This requires
> the handler to do a lookup on an abstract 'tag' which
> identifies the SCSIRequest structure.
> With this patch the SCSIRequest structure is exposed to
> the driver. This allows use to use it directly as an
> argument to the SCSIDeviceInfo callback functions and
> remove the lookup.
> Two new callback functions 'alloc_req' and 'free_req'
> are introduced, which serve to allocate a new request
> and to free up resources after use.

I still think having the implementations of the method named different
than the method name is a bad idea.

Otherwise looks good.