Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

[Stefan Hajnoczi]

On Sat, Nov 20, 2010 at 6:04 PM, Andreas Färber <address@hidden> wrote:
> Am 20.11.2010 um 18:39 schrieb Stefan Hajnoczi:
>
>> On Sat, Nov 20, 2010 at 5:22 PM, Andreas Färber <address@hidden>
>> wrote:
>>>
>>> Any plans for a way to disable NBD build completely? There are warnings
>>> about use of daemon() on Mac OS X and possibly Solaris, and there's
>>> little
>>> point in building qemu-nbd if one does not use it.
>>
>> daemon() could be replaced by sharing os_daemonize().
>>
>> What is the warning message that you get?
>
>  CC    qemu-nbd.o
> /Users/andreas/QEMU/qemu/qemu-nbd.c: In function ‘main’:
> /Users/andreas/QEMU/qemu/qemu-nbd.c:364: warning: ‘daemon’ is deprecated
> (declared at /usr/include/stdlib.h:283)
>
> http://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man3/daemon.3.html

Deprecated in favor of using launchd.

Removing qemu-nbd from the build because there is warning isn't a good
strategy.  You may not use qemu-io either but it is always built.
That's important because otherwise it could bitrot, no one would
notice, and one day qemu-tools wouldn't work on Mac OSX at all
anymore.  Instead we should fix the code that causes a warning.

Is it cheating much to daemonize manually in qemu-nbd? ;)

Stefan